Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI for Apple Platforms #238

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Setup CI for Apple Platforms #238

merged 7 commits into from
Mar 25, 2024

Conversation

xiazhvera
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@xiazhvera xiazhvera marked this pull request as ready for review February 29, 2024 22:19
@xiazhvera xiazhvera changed the base branch from main to iot February 29, 2024 22:27
Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@@ -35,20 +38,44 @@ extension XCTestCase {
}

func skipIfiOS() throws {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debatable: These functions are unused, apart from skipIfLinux. We can just get rid of them until needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will use them soon for IoT related tests. I will keep them here for now.

@xiazhvera xiazhvera merged commit 89698f9 into iot Mar 25, 2024
25 checks passed
@xiazhvera xiazhvera deleted the apple_ci branch March 25, 2024 16:26
@xiazhvera xiazhvera restored the apple_ci branch April 1, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants