Skip to content

Feature createorganizationalunit #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
cd74d54
adds permission to adf-codebuild-role
ethanBaird Mar 14, 2024
b940f39
add tests and stubs
ethanBaird Mar 14, 2024
96d503d
adds method for create_ou
ethanBaird Mar 14, 2024
b8dfec6
ammends get_ou_id
ethanBaird Mar 14, 2024
48fb223
Merge branch 'master' into feature-createorganizationalunit
javydekoning Apr 5, 2024
7928acc
whitespace fixes
ethanBaird Apr 9, 2024
0daba09
Merge branch 'feature-createorganizationalunit' of github.com:ethanBa…
ethanBaird Apr 9, 2024
62a4791
newline
ethanBaird Apr 9, 2024
7c94a5c
raise organizations excpetion
ethanBaird Apr 9, 2024
60532cf
logger.exception
ethanBaird Apr 9, 2024
db464a0
Merge branch 'master' into feature-createorganizationalunit
javydekoning Apr 10, 2024
4798b26
fix linting errors
ethanBaird Apr 10, 2024
955d3e4
Merge branch 'feature-createorganizationalunit' of github.com:ethanBa…
ethanBaird Apr 10, 2024
cf23377
adds permission to adf-codebuild-role
ethanBaird Mar 14, 2024
67db323
add tests and stubs
ethanBaird Mar 14, 2024
d66b571
adds method for create_ou
ethanBaird Mar 14, 2024
9242803
ammends get_ou_id
ethanBaird Mar 14, 2024
911aeef
whitespace fixes
ethanBaird Apr 9, 2024
2cf545c
newline
ethanBaird Apr 9, 2024
2bc03c9
raise organizations excpetion
ethanBaird Apr 9, 2024
e93c3e7
logger.exception
ethanBaird Apr 9, 2024
8a59606
fix linting errors
ethanBaird Apr 10, 2024
f2a8b74
improve exception
ethanBaird Jun 8, 2024
e54fa32
pull and merge
ethanBaird Jun 8, 2024
fa59ef2
add test for create_ou raising OrganizationsException
ethanBaird Jun 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -479,23 +479,37 @@ def get_ou_id(self, ou_path, parent_ou_id=None):
parent_ou_id = self.root_id

# Parse ou_path and find the ID
ou_hierarchy = ou_path.strip("/").split("/")
hierarchy_index = 0
ou_path_as_list = ou_path.strip('/').split('/')

while hierarchy_index < len(ou_hierarchy):
for ou in ou_path_as_list:
org_units = self.list_organizational_units_for_parent(parent_ou_id)
for ou in org_units:
if ou["Name"] == ou_hierarchy[hierarchy_index]:
parent_ou_id = ou["Id"]
hierarchy_index += 1

for org_unit in org_units:
if org_unit["Name"] == ou:
parent_ou_id = org_unit["Id"]
break
else:
raise ValueError(
f"Could not find ou with name {ou_hierarchy} in OU list {org_units}.",
)
LOGGER.info(
'No OU found with name {%s} and parent {%s}, will create.', ou, parent_ou_id
)
new_ou = self.create_ou(parent_ou_id, ou)
parent_ou_id = new_ou['OrganizationalUnit']['Id']

return parent_ou_id

def create_ou(self, parent_ou_id, name):
try:
ou = self.client.create_organizational_unit(
ParentId=parent_ou_id,
Name=name
)
except ClientError as client_err:
message = f'Failed to create OU called {name}, with parent {parent_ou_id}'
LOGGER.exception(message, client_err)
raise OrganizationsException(message) from client_err
return ou


def move_account(self, account_id, ou_path):
self.root_id = self.get_ou_root_id()
ou_id = self.get_ou_id(ou_path)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,24 @@
# adding dependency on datetime
}
}

create_organizational_unit = {
'OrganizationalUnit': {
'Id': 'new_ou_id',
'Arn': 'new_ou_arn',
'Name': 'new_ou_name'
}
}

list_organizational_units_for_parent = [
{
'OrganizationalUnits': [
{
'Id': 'existing_id',
'Arn': 'some_ou_arn',
'Name': 'existing'
},
],
'NextToken': 'string'
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@
import os
import boto3

from pytest import fixture
from pytest import fixture, raises
from stubs import stub_organizations
from mock import Mock, patch
from cache import Cache
from organizations import Organizations, OrganizationsException
from botocore.stub import Stubber
from botocore.exceptions import ClientError
import unittest


Expand All @@ -21,6 +22,32 @@ def cls():
return Organizations(boto3, "123456789012")


def test_create_ou(cls):
cls.client = Mock()
cls.client.create_organizational_unit.return_value = stub_organizations.create_organizational_unit

ou = cls.create_ou("some_parent_id", "some_ou_name")

assert ou['OrganizationalUnit']["Id"] == "new_ou_id"
assert ou['OrganizationalUnit']["Name"] == "new_ou_name"

def test_create_ou_throws_client_error(cls):
cls.client = Mock()
cls.client.create_organizational_unit.side_effect = ClientError(operation_name='test', error_response={'Error': {'Code': 'Test', 'Message': 'Test Message'}})
with raises(OrganizationsException):
cls.create_ou("some_parent_id", "some_ou_name")


def test_get_ou_id_can_create_ou_one_layer(cls):
cls.client = Mock()
cls.client.create_organizational_unit.return_value = stub_organizations.create_organizational_unit
cls.client.get_paginator("list_organizational_units_for_parent").paginate.return_value = stub_organizations.list_organizational_units_for_parent

ou_id = cls.get_ou_id("/existing/new")

assert ou_id == "new_ou_id"


def test_get_parent_info(cls):
cls.client = Mock()
cls.client.list_parents.return_value = stub_organizations.list_parents
Expand Down
1 change: 1 addition & 0 deletions src/template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1256,6 +1256,7 @@ Resources:
- "logs:PutLogEvents"
- "organizations:AttachPolicy"
- "organizations:CreatePolicy"
- "organizations:CreateOrganizationalUnit"
- "organizations:DeletePolicy"
- "organizations:DescribeAccount"
- "organizations:DescribeOrganization"
Expand Down