Fix jump role policy generation when bootstrapping > 361 accounts #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: awslabs#750 ## Why? The calculation for the maximum number of accounts that can be supported with the jump role manager in one go was incorrect. Among other things, the calculation did not take into account the maximum length of a role name. ## What? * Added tests to validate future changes of the policy generation process will generate policies of a supported length. * Fixed the calculation to include the maximum role name length of 64 characters.
javydekoning
approved these changes
Aug 8, 2024
danxie1999
pushed a commit
to danxie1999/aws-deployment-framework
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #750
Why?
The calculation for the maximum number of accounts that can be supported with the jump role manager in one go was incorrect.
Among other things, the calculation did not take into account the maximum length of a role name.
What?
By submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.