Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lambda-http deps #189

Merged
merged 1 commit into from
Jan 1, 2020

Conversation

skorobkov
Copy link

When cargo get dependencies it parses all Cargo.toml which it finds.
Because of that you can't just add to your Cargo.toml
lambda = {git = "https://github.com/awslabs/aws-lambda-rust-runtime", branch = "async-await"}
cargo will stop with error:

$ cargo check
    Updating git repository `https://github.com/awslabs/aws-lambda-rust-runtime.git`
error: failed to load source for a dependency on `lambda`

Caused by:
  Unable to update https://github.com/awslabs/aws-lambda-rust-runtime.git?branch=async-await

Caused by:
  Could not find `Cargo.toml` in `/Users/user/.cargo/git/checkouts/aws-lambda-rust-runtime-7c865cce90132439/1b95ac1/lambda-runtime`

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@skorobkov
Copy link
Author

If you put like
lambda = {path = "vendor/aws-lambda-rust-runtime/lambda"}
then everything is ok.

Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidbarsky davidbarsky merged commit 2d37c34 into awslabs:async-await Jan 1, 2020
@skorobkov skorobkov deleted the fix/lambda-http-deps branch January 3, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants