-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade http to 0.2 #199
Upgrade http to 0.2 #199
Conversation
Hmmm, I think that the build failure is that http 0.2 introduces a dependency on bytes which doesn't compile under Rust 1.31. Would you be open to upgrading the minimum required Rust version? |
@LinusU Yeah, bumping the minimum supported Rust version would help. That being said, I am a bit worried about introducing http 0.2 without also bumping Hyper to 0.13, as there will be duplicate instances of For what it's worth, we're also doing bump of |
Hehe, yeah, in fact getting those error messages and spending a lot of time trying to figure out why is why I bumped these versions 😁 Getting #111 in is probably a better idea as you say 👍 My use case is to slightly modify the hyper http server to feed it requests from Lambda, so that you can take any already existing http server that's based on hyper (e.g. a warp app) and deploy it to Lambda with just one command ( Should we just close this one out in favour of #111? |
Ah yeah. One of the reasons #111 took a while was:
Perhaps—feel free to pull down my branch and try it out for your needs! |
@davidbarsky rebased this on It seems like edit: actually, it seems like there is a bit of work required in The readme also mentions |
Thanks for the rebase!
It was intentional, as it'll require a decent amount of fixing up to work with the new rutime semantics and for it to support the new Lambda invocation format introduced with API Gateway's HTTP APIs. I'll accept a PR, but I also know its a non-trivial amount of work to be done correctly.
Yup! 😅 |
This can be closed now. An upgrade with the http crate came with the last update to the lambda http module |
Description of changes: Bumps the http crate to version 0.2
closes #196
change log: https://github.com/hyperium/http/releases/tag/v0.2.0
By submitting this pull request