Skip to content

Float support on sliders #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

mathieucarbou
Copy link
Contributor

Reopening #230 which I think was mistakenly closed by a misunderstanding of the PR content.

@mathieucarbou
Copy link
Contributor Author

mathieucarbou commented Aug 3, 2024

The code is backward compatible, even if a user uses the int constructor but calls update(float).

The UI already supports such changes.

Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR is marked as stale because it has been open 45 days with no activity. You can remove stale label or comment if this PR is still valid.

@github-actions github-actions bot added the Stale label Sep 3, 2024
@mathieucarbou
Copy link
Contributor Author

@ayushsharma82 : what about this PR ? ;-)

@github-actions github-actions bot removed the Stale label Sep 16, 2024
@ayushsharma82 ayushsharma82 merged commit 8ab0294 into ayushsharma82:dev Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants