Skip to content

Update version and CI #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2024
Merged

Update version and CI #237

merged 2 commits into from
Oct 13, 2024

Conversation

mathieucarbou
Copy link
Contributor

No description provided.

@mathieucarbou
Copy link
Contributor Author

mathieucarbou commented Oct 4, 2024 •
edited
Loading

@ayushsharma82 : you had an issue in the code preventing lib update.

even if we could argue that changing from void to bool in a return type is a signature change, I don't think this is a good idea for forward compatibility to use return with a void function.

Note: the bug is also in the pro version.

@mathieucarbou mathieucarbou changed the title Update Update version and CI Oct 4, 2024
@ayushsharma82 ayushsharma82 merged commit a9ec6b2 into ayushsharma82:dev Oct 13, 2024
19 checks passed
@mathieucarbou mathieucarbou deleted the update branch November 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushsharma82 ayushsharma82 ayushsharma82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieucarbou @ayushsharma82