nestjs: use ESM modules #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konraddysput
approved these changes
Aug 23, 2024
packages/nestjs/package.json
Outdated
| @@ -41,23 +43,23 @@ | |||
| "/lib" | |||
| ], | |||
| "devDependencies": { | |||
| "@backtrace/node": "^0.3.1", | |||
There was a problem hiding this comment.
why backtrace/node is a dev dependency here?
There was a problem hiding this comment.
good catch, should be in normal deps, changed
perf2711
force-pushed
the
feature/esm-modules--nestjs
branch
4 times, most recently
from
7db3a04 to
380709f
Compare
perf2711
force-pushed
the
feature/esm-modules--nestjs
branch
from
380709f to
141c656
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ESM module support to
nestjs.nestjsis now bundled into two files:bundle.mjs- ESM modulesbundle.cjs- CommomJS (Node) modules