ci: additional smoke tests #283
Conversation
perf2711
force-pushed
the
ci/more-smoke-tests
branch
from
ddf4896 to
8e7fba1
Compare
perf2711
force-pushed
the
ci/more-smoke-tests
branch
from
2bea8d3 to
62894b6
Compare
perf2711
force-pushed
the
ci/more-smoke-tests
branch
from
aefadb8 to
e18a026
Compare
There was a problem hiding this comment.
e2e tests are important and I'm happy that we're doing this. I'm not fully sure what is the idea for the smoketest project - how it should work in the dev environment or in cicd pipeline. I have a lot of open questions related to flow. Does it make sense to also add a README file with information what is this project and what it does/how to use it?
|
|
||
| export function npm(cwd: string, args: string[], options?: SpawnOptionsWithoutStdio) { | ||
| export function npm(cwd: string, args: string[], options?: AsyncSpawnOptions) { |
There was a problem hiding this comment.
we talked about this on Slack but I still dont get it:
Questions:
- Why do we need to write scripts around this. Why we cannot just use CICD pipeline setup.
- if we're already in the npm workspace, why the development process is hard? We can just have a watch process. We don't need to install every time npm packages or clean them.
- Why it's not enough to use npm workspace and the same actions. We can execute all actions in a single workspace that has a task node:e2e or browser:e2e.
- Why do we need to have a dedicated project for smoke tests?
There was a problem hiding this comment.
Why do we need to write scripts around this. Why we cannot just use CICD pipeline setup.
We want the developer to be able to run the tests without CICD pipelines.
if we're already in the npm workspace, why the development process is hard? We can just have a watch process. We don't need to install every time npm packages or clean them.
You can definitely do that if you want. Install NPM packages yourself, set up a watch process, and run the test.
Why it's not enough to use npm workspace and the same actions. We can execute all actions in a single workspace that has a task node:e2e or browser:e2e.
Installing the packages by itself is a test. I wanted to separate this.
Why do we need to have a dedicated project for smoke tests?
Why not? Where you would put it otherwise?
This PR adds new smoke tests for Node, testing combinations of JS/TS and ESM/CJS.
This also adds a WDIO smoke test run on Sauce Labs for React SDK with Session Replay.