Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native: fix previous sessions not being cleared #306

Merged
merged 2 commits into from
Oct 23, 2024
Merged

react-native: fix previous sessions not being cleared #306

merged 2 commits into from
Oct 23, 2024

Conversation

perf2711
Copy link
Contributor

This PR fixes previous sessions not being cleared, even if they are not locked.
The reasons were:

  • Android implementation of readDirSync returned full paths instead of file names (suprisingly, asynchronous readDir is implemented correctly)
  • previous sessions were not unlocked when error was not thrown in BacktraceClient.initialize (replaced catch with finally

@perf2711 perf2711 added the bug Something isn't working label Oct 23, 2024
@perf2711 perf2711 requested a review from konraddysput October 23, 2024 10:36
@perf2711 perf2711 self-assigned this Oct 23, 2024
@perf2711 perf2711 merged commit 3752f71 into main Oct 23, 2024
5 checks passed
@perf2711 perf2711 deleted the bugfix/BT-5146-rn-sessions-not-cleared branch October 23, 2024 12:23
@perf2711 perf2711 removed this from the React Native New Architecture milestone Oct 23, 2024
@perf2711 perf2711 mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konraddysput konraddysput konraddysput approved these changes

Assignees

@perf2711 perf2711

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perf2711 @konraddysput