Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to merge sketch databases #22

Merged
merged 20 commits into from
Aug 5, 2024
Merged

Add command to merge sketch databases #22

merged 20 commits into from
Aug 5, 2024

Conversation

johannahelene
Copy link
Collaborator

No description provided.

@johannahelene johannahelene requested a review from johnlees July 25, 2024 11:51
johnlees
johnlees requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, some which you can do, some which I should help you with, so let's discuss.

We should also set up github actions to run tests and linting automatically.

@johannahelene johannahelene requested a review from johnlees August 5, 2024 10:42
johnlees
johnlees approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@johnlees johnlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some further style changes and changes to tests

@johnlees johnlees merged commit 35e4258 into main Aug 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlees johnlees johnlees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannahelene @johnlees