fix package-lock.json to restore heroku deploys

[calebcartwright]

Heroku deploys are failing again with missing dependencies that seem to be related to the package-lock.json file

#3898 (comment)
https://dashboard.heroku.com/pipelines/d8fd42e8-8e42-466e-98fc-f5f50edbdd8f

[shields-ci]

	Warnings
⚠️	This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

	Messages
📖	✨ Thanks for your contribution to Shields, @calebcartwright!

Generated by 🚫 dangerJS against 937fa4a

[calebcartwright]

No such luck 🤔 I'm gonna see if I can get dependabot to open a PR with a fix

[paulmelnikow]

@calebcartwright Have you tried updating to the latest npm? I’m not following development super closely but there were some recent regressions on Windows that were fixed in the latest version.

[paulmelnikow]

I'll give this a second shot. I think the last known working deploy was 316749b so I'll start by reverting to that.

[paulmelnikow]

I wonder if this is not a problem with the lockfile, but with the npm installer. If I blow away my local node_modules and re-run npm install, I can reproduce the problem locally.

[paulmelnikow]

From the build log:

       We're sorry this build is failing! You can troubleshoot common issues here:
       https://devcenter.heroku.com/articles/troubleshooting-node-deploys
       
       Some possible problems:
       
       - Dangerous semver range (>) in engines.node
         https://devcenter.heroku.com/articles/nodejs-support#specifying-a-node-js-version

[calebcartwright]

If I blow away my local node_modules and re-run npm install, I can reproduce the problem locally.

Ditto. I just remembered that last time I ran into this I had to delete the node_modules directory in the root of the project as well as the one within the gh-badges directory.

🤞

[calebcartwright]

I'm on node 8.x and npm 5.x at the moment. I have node 10 on Windows so I guess I can give that a try too, especially since nothing else seems to be working 😄

[paulmelnikow]

I wonder if I was wrong about which was the last known working version.

[calebcartwright]

I'm baffled. I know this is the most unhelpful thing commonly said by engineers, but it works on my machine!

[paulmelnikow]

Can you give me steps to produce a good install on this commit? I can try it on my machine.

The commit on #3909 is not working on my machine.

[calebcartwright]

For me a rm -rf on node_modules and gh-badges/node-modules and then an npm i and npm start. I can also run an npm ci in there

[calebcartwright]

Cool! Yea, by default env vars don’t propagate from the staging app to the review apps (which is a good thing, really).

Definitely! I had explicitly specified my review app though (heroku config:set CYPRESS_INSTALL_BINARY=0 --app shields-staging-pr-3904) which I figured would have worked.

I also tried setting them in app.json but they don't seem to be working their either 🤷‍♂

[calebcartwright]

Even using strings for the env values in app.json didn't seem to have an impact

...
[19:16:11]  Unzipping Cypress        98% 1s [title changed]
       [19:16:11]  Unzipping Cypress        99% 1s [title changed]
       [19:16:12]  Unzipping Cypress        100% 0s [title changed]
       [19:16:12]  Unzipped Cypress        [title changed]
       [19:16:12]  Unzipped Cypress        [completed]
       [19:16:12]  Finishing Installation  [started]
       [19:16:12]  Finished Installation   /app/.cache/Cypress/3.4.1 [title changed]
       [19:16:12]  Finished Installation   /app/.cache/Cypress/3.4.1 [completed]
       �[?25h
       You can now open Cypress by running: node_modules/.bin/cypress open
       
       https://on.cypress.io/installing-cypress

[paulmelnikow]

Gosh, so much strangeness!

I'm guessing the problem we are running into is a recent regression in npm, and something we ought to report so it can be fixed. I haven't had much time at the keyboard in recent weeks and haven't had too much time to dig into this myself. Though its effects are kind of far-reaching (e.g. #3901) and I feel like we need to get to the bottom of it.

[calebcartwright]

Perhaps this is related? https://npm.community/t/6-11-1-some-dependencies-are-no-longer-being-installed/9586

[paulmelnikow]

It looks like that is the solution: npm install -g [email protected] makes the problem go away.

Steps to reproduce the problem:

npm install -g [email protected]
rm -rf node_modules
npm install
ls -d node_modules/is-css-color

[calebcartwright]

I can't approve this as the author but 👍 from me

[shields-deployment]

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch: