Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Simplify full namespaces" #1007

Closed
bbprojectnet opened this issue Aug 13, 2020 · 14 comments · Fixed by #1031
Closed

Disable "Simplify full namespaces" #1007

bbprojectnet opened this issue Aug 13, 2020 · 14 comments · Fixed by #1031

Comments

@bbprojectnet
Copy link

Hi,

How to disable "Simplify full namespaces for already included resources" and keep FQCN like in version 2.7?

@barryvdh
Copy link
Owner

What is the problem with it?

@bbprojectnet
Copy link
Author

Hi,

Nothing :) but i have conventions adopted in the project, using only FQCN in any PHPDoc. After update to version 2.8, suddenly i have to commit many files because this little change ;) I want to avoid this and stay fine with convention.

I think will be great if i can turn on/off this behaviour in config file. What do you think? :)

@mfn
Copy link
Collaborator

mfn commented Aug 14, 2020

Yet another config 😢

@mfn
Copy link
Collaborator

mfn commented Aug 14, 2020

Btw, I can understand it's at least confusing because the changelog mentions nothing related to this.

@bbprojectnet
Copy link
Author

Yet another config 😢

No, just one new entry in ide-helper.php :)

@mfn
Copy link
Collaborator

mfn commented Aug 14, 2020

IMHO there should be more technical justification for this instead of not liking / wanting to commit this… 🤷‍♀️

@bbprojectnet
Copy link
Author

There is - backward compatybility. I like laravel-ide-helper and how it works (until 2.7). So, if that major change is introduced, it should by as an option and in default behave like before, or at least give an option to switch to old behaviour.

For me, laravel-ide-helper is not a only tool for help IDE, but also visual aspect of code (PHPDoc blocks).

@mfn
Copy link
Collaborator

mfn commented Aug 14, 2020

backward compatybility

Can you point it what it breaks?

@bbprojectnet
Copy link
Author

Style of PHPDoc block.

@mfn
Copy link
Collaborator

mfn commented Aug 14, 2020

So you are using php-cs-fixer or similar which now breaks on this?

@bbprojectnet
Copy link
Author

Yes, I'm also using PHP CS Fixer, but they have plenty of options which i can achieve desirable effect of code formating. There has never been a situation where from version to version change behavior of some functionality without option to control it.

@bbprojectnet
Copy link
Author

bbprojectnet commented Aug 14, 2020

I probably missunderstand your message... yes, php-cs-fixer works fine, code works fine... etc. I know what you're getting at.

Look, if suddenly ide helper change all \n to spaces it will be ok or not? Code will work, everything will be fine but this still was a bug. Same with change FQCN to only class name, but the impact is lower.

IDE helper has his config file, why it is so big deal to add there another option to control his behaviour (in FQCN aspect)? Like many others in there.

@edvordo
Copy link
Contributor

edvordo commented Aug 30, 2020

I would also very much welcome a way to disable this. I want to use FQCN everywhere, even the class is in the same file. All my projects use FQCN everywhere, even outside of models, simplification is very much undesirable behaviour for me.

@mfn
Copy link
Collaborator

mfn commented Aug 31, 2020

😢

I guess we're accepting PRs then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants