Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property issues with 2.13.0 #1419

Closed
makroxyz opened this issue Feb 8, 2023 · 12 comments
Closed

Property issues with 2.13.0 #1419

makroxyz opened this issue Feb 8, 2023 · 12 comments
Labels

Comments

@makroxyz
Copy link

makroxyz commented Feb 8, 2023

Versions:

  • ide-helper Version: 2.13.0
  • Laravel Version: 9.51
  • PHP Version: 8.1.9

Description:

Some props are now @property-write and it seems boolean are skipped so larastan now generates a lot of errors

Worked fine with previous version

@makroxyz makroxyz added the bug label Feb 8, 2023
@makroxyz makroxyz changed the title property-write when using --write-mixin Property issues with 2.13.0 Feb 8, 2023
@mfn
Copy link
Collaborator

mfn commented Feb 8, 2023

Some more details, examples, test case etc. would be nice.

@Sergiobop
Copy link

I don't know if this is the same issue that some users are experiencing @mfn

After #1298, every time the model command is ran, some generic annotations are being duplicated even if they are already in the phpdoc.

Some comments about it:
#1298 (comment)
#1298 (comment)

@benpoulson
Copy link
Contributor

benpoulson commented Feb 21, 2023

Same issue here;

Occurs on both Laravel 9.52.0 & 10.0.0.
2.12.3 worked fine, ^2.13.0 failing with the below result.
Unable to provide code examples, but I can say that I'm using multiple MySQL connections.

image

@benpoulson
Copy link
Contributor

@makroxyz Are you doing anything like overriding getTable() on your models?

@benpoulson
Copy link
Contributor

benpoulson commented Feb 21, 2023

I believe it's due to removal of these:
v2.12.3...v2.13.0#diff-2df8ee218526540f71334c651990edfbfe5345cc53a521b0259c874ff24abd9aL484-L489

image

Adding them back in allowed my multi-db project to function as normal.
Submitted a PR to reintroduce that snippet here: #1426

@makroxyz
Copy link
Author

@benpoulson I confirm I have multi database project and in some models getTable() method has been overridden.

@makroxyz
Copy link
Author

@mfn could you have a look at this post please? There are a lot of new informations.

@makroxyz
Copy link
Author

makroxyz commented May 3, 2023

Up!!

@ThomasSfflx
Copy link

Up @barryvdh

@mfn
Copy link
Collaborator

mfn commented Feb 16, 2024

Sorry, we know it has been along time.

Does this still happen with the latest version (we just made some releases)?

@benpoulson
Copy link
Contributor

@mfn - looks like #1426 got merged, so v2.15.0 should contain it.

@mfn
Copy link
Collaborator

mfn commented Feb 16, 2024

Thanks, you're right 🫡 Closing in good faith then…

@mfn mfn closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants