Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to introduce a discount system into the system #119

Merged
merged 11 commits into from
Oct 3, 2019
Merged

Conversation

rez1dent3
Copy link
Member

@rez1dent3 rez1dent3 commented Oct 2, 2019

#117

  • Pay
  • Free pay
  • Gift
  • Taxing
  • Free Pay + Discount
  • Pay + Discount + Taxing
  • Refund
  • Add wallet price calculation

@rez1dent3 rez1dent3 added enhancement New feature or request invalid This doesn't seem right labels Oct 2, 2019
@rez1dent3 rez1dent3 self-assigned this Oct 2, 2019
@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #119 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #119   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      235    240    +5     
=======================================
  Files            23     23           
  Lines           640    658   +18     
=======================================
+ Hits            640    658   +18
Impacted Files Coverage Δ Complexity Δ
src/Objects/Cart.php 100% <100%> (ø) 18 <2> (ø) ⬇️
src/Traits/HasWallet.php 100% <100%> (ø) 21 <0> (ø) ⬇️
src/WalletServiceProvider.php 100% <100%> (ø) 1 <0> (ø) ⬇️
src/Traits/HasGift.php 100% <100%> (ø) 6 <0> (ø) ⬇️
src/Traits/MorphOneWallet.php 100% <100%> (ø) 2 <0> (ø) ⬇️
src/Services/WalletService.php 100% <100%> (ø) 18 <3> (+3) ⬆️
src/Objects/Bring.php 100% <100%> (ø) 19 <2> (+2) ⬆️
src/Traits/CartPay.php 100% <100%> (ø) 24 <0> (ø) ⬇️
src/Services/CommonService.php 100% <100%> (ø) 21 <0> (ø) ⬇️
src/Traits/CanExchange.php 100% <100%> (ø) 8 <0> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158a9b7...6142983. Read the comment docs.

@rez1dent3 rez1dent3 removed the invalid This doesn't seem right label Oct 3, 2019
@rez1dent3 rez1dent3 added the bug Something isn't working label Oct 3, 2019
@rez1dent3 rez1dent3 merged commit 1877fd9 into master Oct 3, 2019
@rez1dent3 rez1dent3 deleted the discount branch October 3, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant