Fixed migration issue with db table prefix #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #195 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 303 303
===========================================
Files 25 25
Lines 822 848 +26
===========================================
+ Hits 822 848 +26
Continue to review full report at Codecov.
|
|
@reedknight @cispl-shaswatad Thanks you. I ran unit testing. I will release tomorrow |
Merged
rez1dent3
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faced issue while executing migrations. Identified that in some migrations, DB::statement is being used and when DB Table Prefix is configured in the config/database.php file, it is not building the correct table names in those statements.
For the fix, the
DB::getTablePrefix()is appended to all the places where the table name is being used as a direct statement.Kindly accept PR or share feedback for corrections if required.