Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit #349

Merged
merged 2 commits into from
Aug 10, 2021
Merged

add unit #349

merged 2 commits into from
Aug 10, 2021

Conversation

rez1dent3
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #349 (c520331) into master (392906f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #349   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       255       255           
===========================================
  Files             26        26           
  Lines            861       861           
===========================================
  Hits             861       861           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 392906f...c520331. Read the comment docs.

self::assertNotNull($user->wallet);
self::assertEquals($user->wallet->id, $wallet->id);

$user->deposit(1000000000);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rez1dent3 could you please change this to $wallet->deposit(1000000000); instead of $user->deposit and give it a try?

Copy link

@iamroi iamroi Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rez1dent3 after double checking the test $user->deposit is actually the same as $wallet->deposit so it's all correct.

I'm not sure why I'm getting that weird issue

@rez1dent3 rez1dent3 deleted the issue_348 branch September 28, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants