Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking backward compatibility #448

Merged
merged 11 commits into from
Mar 13, 2022
Merged

breaking backward compatibility #448

merged 11 commits into from
Mar 13, 2022

Conversation

rez1dent3
Copy link
Member

I advised to use setMeta, but it seems to me that we need to move away from this approach towards "fluent dto". Not the fact that this MR will reach the release. #446

@rez1dent3 rez1dent3 added the dependencies Pull requests that update a dependency file label Feb 26, 2022
@rez1dent3 rez1dent3 self-assigned this Feb 26, 2022
@rez1dent3 rez1dent3 marked this pull request as draft February 26, 2022 09:10
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 13017a3
Status: ✅  Deploy successful!
Preview URL: https://8f7ade24.laravel-wallet.pages.dev

View logs

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #448 (13017a3) into master (36a3bdb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #448   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       384       385    +1     
===========================================
  Files             62        62           
  Lines           1151      1161   +10     
===========================================
+ Hits            1151      1161   +10     
Impacted Files Coverage Δ
...c/Internal/Assembler/TransactionQueryAssembler.php 100.00% <ø> (ø)
src/Internal/Assembler/TransferQueryAssembler.php 100.00% <ø> (ø)
src/Services/ExchangeService.php 100.00% <ø> (ø)
src/Traits/HasWallets.php 100.00% <ø> (ø)
src/Traits/MorphOneWallet.php 100.00% <ø> (ø)
...nternal/Assembler/BalanceUpdatedEventAssembler.php 100.00% <100.00%> (ø)
src/Internal/Assembler/TransactionDtoAssembler.php 100.00% <100.00%> (ø)
src/Internal/Assembler/TransferDtoAssembler.php 100.00% <100.00%> (ø)
...rc/Internal/Assembler/TransferLazyDtoAssembler.php 100.00% <100.00%> (ø)
...Internal/Assembler/WalletCreatedEventAssembler.php 100.00% <100.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36a3bdb...13017a3. Read the comment docs.

@rez1dent3 rez1dent3 marked this pull request as ready for review February 26, 2022 22:11
@rez1dent3 rez1dent3 changed the title towards fluent dto breaking backward compatibility Feb 26, 2022
@rez1dent3 rez1dent3 merged commit 7a30789 into master Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant