feat: updateOrAddMeta for wallet

[justinkekeocha]

It will be nice to have a method that updates or adds a new key to the meta.

Just like what you did here: https://github.com/bavix/laravel-wallet/issues/498#issuecomment-1124005291

[codecov]

Codecov Report

Merging #767 (d87ea69) into master (bd9b73b) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

❗ Current head d87ea69 differs from pull request most recent head 14be368. Consider uploading reports for the commit 14be368 to get more accurate results

@@              Coverage Diff              @@
##              master     #767      +/-   ##
=============================================
- Coverage     100.00%   99.89%   -0.11%     
- Complexity       551      552       +1     
=============================================
  Files             83       83              
  Lines           1946     1948       +2     
=============================================
  Hits            1946     1946              
- Misses             0        2       +2     

Files Changed	Coverage Δ
src/Models/Wallet.php	93.93% <0.00%> (-6.07%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rez1dent3]

Thank you for your contribution to the project, but I can't add this feature to the wallet model.

This functionality should be located in the area of the team that is developing its software product. Here's how to define replace or merge at the package level? How to solve a problem with a depth greater than 1?

In addition, the name of the method is not correct. By update, people understand an sql operation, because this method is in the model.

Here is a small example for you:

$meta = [
	'order' => [
		'id' => '92e330ec-c248-48a7-b7c2-a7d48535e417',
		'items' => [1,2,3,4,15],
	],
];

$meta = array_merge($meta, [
	'order' => [
		'title' => 'Message',
	],	
]);

/*
array(1) {
  ["order"]=>
  array(1) {
    ["title"]=>
    string(7) "Message"
  }
}
*/

[justinkekeocha]

The code above does not remove existing records when saved if that is what you mean. Maybe you should actually run the method.

[rez1dent3]

The code above does not remove existing records when saved if that is what you mean. Maybe you should actually run the method.

I see and understand, I'm talking about the name and area of responsibility. The formation of a meta array is not the responsibility of the package.

[justinkekeocha]

Name can be changed to what will best describe it. I was just trying to add more helpers like the Eloquent updateOrCreate() method.

[rez1dent3]

I understand, but this is not the responsibility of the package. Here you need to approach conservatively, according to the principle of YAGNI (You Aren't Gonna Need It). The package develops from the feedback received, this functionality is superfluous. The more functions we add, the more difficult and expensive refactoring is. As part of the package, we do not solve the problems that developers have with php. Here we are developing an API for working on the wallet.

If you are looking for useful functionality, then please develop the balance with credit method. The point is to display the full balance along with the credit limit. You can read about the functionality here: https://bavix.github.io/laravel-wallet/#/credit-limits

UPD: Only necessarily new functionality must be covered by unit tests.

[justinkekeocha]

I tried that, but it didn't work, which was was what set me searching.

[rez1dent3]

Sorry, I didn't catch the context. Can you tell me more about what you're talking about?

[justinkekeocha]

Quick question: supposing I want to extend the wallet.php model to add the feature for my own custom app. How would I do this. From going through the codebase, the MorphOne trait, has a wallet method which calls the wallet model. The getWalletAttribute() also calls a CastServiceInterface.

But I couldn't find a way to extend the model.

[rez1dent3]

@justinkekeocha You need to expand the model and replace it through the config.

laravel-wallet/config/config.php

Line 184 in 9b0bd38

'model' => Wallet::class,

Example MyWallet.php:

use Bavix\Wallet\Models\Wallet as WalletBase;

class MyWallet extends WalletBase {
    public function helloWorld(): string { return "hello world"; }
}

config/wallet.php

...
    'wallet' => [
        'table' => 'wallets',
        'model' => MyWallet::class,
        'creating' => [],
        'default' => [
            'name' => 'Default Wallet',
            'slug' => 'default',
            'meta' => [],
        ],
    ],
...

echo $user->wallet->helloWorld();

UPD: Even now I’ll try to write a unit test for this and attach it below.

[rez1dent3]

@justinkekeocha https://github.com/bavix/laravel-wallet/pull/769/files

[rez1dent3]

I don't see any benefit for the package with this PR, I'm really sorry. I'm closing the pull request.
Thank you for your contribution to the development of the project.

[rez1dent3]

Can you please document this expansion, I really struggled to expand this model and I believe it is the same with other. If this will be much of a hassle for you, you can recommend which page I can put it in the documentation

@justinkekeocha It seems to me that a new section in the documentation needs to be created for this. If you have a desire, please add.

[justinkekeocha]

I have done this here : https://github.com/bavix/laravel-wallet/pull/770

Is there a way to extend the Transaction and Transfer class?

I am guessing it is editing this

` /**
* Base model 'transaction'.
*/
'transaction' => [
'table' => 'transactions',
'model' => Transaction::class,
],

/**
 * Base model 'transfer'.
 */
'transfer' => [
    'table' => 'transfers',
    'model' => Transfer::class,
],`

If yes, then let me go forward with the same way I did with the Wallet class

[rez1dent3]

Yes you are right. It's similar there.