Consider writing deps hash into the Xcode project #2
Comments
jerrymarino
added a commit
that referenced
this issue
Mar 14, 2018
We were previously writing the depsHash into a file. It's possible in rare circumstances that this file gets out of sync with the Xcode project. Fixes #2
jerrymarino
added a commit
that referenced
this issue
Mar 14, 2018
We were previously writing `depsHash` into `XCHammerAssets/depsHash` in an atomic transaction. Despite this, it's possible in rare circumstances that this file gets out of sync with the Xcode project. For example, if Xcode decides to write the in memory representation of the project ontop of our changes. This patch uses the file system metadata to associate the `project.pbxproj` with a given `depsHash` Fixes #2
jerrymarino
added a commit
that referenced
this issue
Mar 14, 2018
We were previously writing `depsHash` into `XCHammerAssets/depsHash` in an atomic transaction. Despite this, it's possible in rare circumstances that this file gets out of sync with the Xcode project. For example, if Xcode decides to write the in memory representation of the project ontop of our changes. This patch associates the `project.pbxproj` with a given `depsHash` by writing it into a user defined build setting. We attempt to read it from the env if it exists, otherwise, quickly parse it from the project. Additionally, I took the liberty to address #1 due for stability reasons. If the file system changes during generation ( unfortunately possible ), we will have saved the hash that we built the project with. Fixes #2 Fixes #1
jerrymarino
added a commit
that referenced
this issue
Mar 14, 2018
We were previously writing `depsHash` into `XCHammerAssets/depsHash` in an atomic transaction. Despite this, it's possible in rare circumstances that this file gets out of sync with the Xcode project. For example, if Xcode decides to write the in memory representation of the project ontop of our changes. This patch associates the `project.pbxproj` with a given `depsHash` by writing it into a user defined build setting. We attempt to read it from the env if it exists, otherwise, quickly parse it from the project. Additionally, I took the liberty to address #1 due for stability reasons. If the file system changes during generation ( unfortunately possible ), we will have saved the hash that we built the project with. Fixes #2 Fixes #1
jerrymarino
added a commit
that referenced
this issue
Mar 14, 2018
We were previously writing `depsHash` into `XCHammerAssets/depsHash` in an atomic transaction. Despite this, it's possible in rare circumstances that this file gets out of sync with the Xcode project. For example, if Xcode decides to write the in memory representation of the project ontop of our changes. This patch associates the `project.pbxproj` with a given `depsHash` by writing it into a user defined build setting. We attempt to read it from the env if it exists, otherwise, quickly parse it from the project. Additionally, I took the liberty to address #1 due for stability reasons. If the file system changes during generation ( unfortunately possible ), we will have saved the hash that we built the project with. Fixes #2 Fixes #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use a hash to determine if a project should be generated or not.
There are some circumstances where having the deps hash in an external file may not be ideal.
For example, when the user is prompted by Xcode the project has changed. If the user selects
Keep Xcode Version, then they will end up with an incorrect project.Writing the hash into the project ensures the hash always matches the Xcode project in obscure cases.
The text was updated successfully, but these errors were encountered: