Implement generation status #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch utilizes a file to track XCHammer updates. When the generator successfully runs, we create the file.
rahul-malik
reviewed
Mar 16, 2018
| tempProjectPath) | ||
| guard FileManager.default.createFile(atPath: genStatusPath, | ||
| contents: "".data(using: .utf8), attributes: nil) else { | ||
| fatalError("Can't write genStatus") |
There was a problem hiding this comment.
What does this mean for people that run xchammer? We should have something helpful here
There was a problem hiding this comment.
None of the of the fatals here are meaningful to users, as they're invalid program states ( fatal errors ). Perhaps we should cull them into a fatal XCHammer that is more clear.
rahul-malik
reviewed
Mar 16, 2018
| xcworkspacePath) | ||
| guard FileManager.default.createFile(atPath: genStatusPath, | ||
| contents: "".data(using: .utf8), attributes: nil) else { | ||
| fatalError("Can't write genStatus") |
rahul-malik
reviewed
Mar 16, 2018
| if [[ $ACTION == "clean" ]]; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| PREV_STAT=`stat -f %c "$0"` | ||
| PREV_STAT=`stat -f %c "/Users/jerry/Projects/xchammer-github/sample/UrlGet/UrlGet.xcodeproj/XCHammerAssets/genStatus"` |
There was a problem hiding this comment.
are you expecting absolute paths here? remove
There was a problem hiding this comment.
Yep we're using absolute paths, and unfortunately, they are all hardcoded to the last persons computer.
There was a problem hiding this comment.
We should have a better way..
|
Thanks for the review @rahul-malik - I filed a ticket to rework the sample to a golden file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch utilizes a file to track XCHammer updates.
When the generator successfully runs, we create the file.