add Cortex-M to supported target lists. #1914
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested changes
Apr 5, 2023
rust/platform/platform.bzl
Outdated
| @@ -19,6 +19,9 @@ _SUPPORTED_CPU_ARCH = [ | |||
| "x86_64", | |||
| "riscv32", | |||
| "riscv64", | |||
| "thumbv6m", | |||
There was a problem hiding this comment.
Are there actually platform definitions for this in https://github.com/bazelbuild/platforms/blob/main/cpu/BUILD ?
I feel like this needs to be mapped to something or a PR to that repo needs to be added, right?
There was a problem hiding this comment.
Actually good point. I don't think these are really needed for this change anyways.
These targets are listed as T2 supported target by rust.
|
Also can you give some advice on why the CI is failing? Do you know why / if / how should I repin the lock file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These targets are listed as T2 supported target by rust.