Skip to content

Rename vendor_local_pkgs to local_pkgs #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

scentini
Copy link
Collaborator

@scentini scentini commented May 2, 2023

To address #1946

I wanted to remove all the vendor prefixes, however I couldn't easily figure out how to deal with vendor_local_manifests and vendor_remote_manifests; the error message I was getting was:

File "/.../rules_rust/examples/crate_universe/local_manifests/crates/defs.bzl", line 197, column 17, in all_crate_deps
		fail("Tried to get all_crate_deps for package " + package_name + " but that package had no Cargo.toml file")
Error in fail: Tried to get all_crate_deps for package local_manifests but that package had no Cargo.toml file

So I'll be working on them one by one. Any hints are greatly appreciated!

@scentini scentini marked this pull request as ready for review May 2, 2023 20:07
@scentini scentini requested a review from UebelAndre May 2, 2023 20:08
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to remove all the vendor prefixes, however I couldn't easily figure out how to deal with vendor_local_manifests and vendor_remote_manifests; the error message I was getting was:

File "/.../rules_rust/examples/crate_universe/local_manifests/crates/defs.bzl", line 197, column 17, in all_crate_deps
		fail("Tried to get all_crate_deps for package " + package_name + " but that > package had no Cargo.toml file")
Error in fail: Tried to get all_crate_deps for package local_manifests but that package had > no Cargo.toml file

So I'll be working on them one by one. Any hints are greatly appreciated!

This feels like a bootstrapping issue. Moving the files will make some of the rendered content incorrect and it seems the dependencies API will become unusable. Maybe finding the all_crate_deps function and having it return an empty list would help move you forward so you can regenerate outputs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants