Skip to content

Example of rust dynamically linking cc shared library #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Example of rust dynamically linking cc shared library #2061

wants to merge 2 commits into from

Conversation

daivinhtran
Copy link
Contributor

@daivinhtran daivinhtran commented Jul 13, 2023 •
edited
Loading

No description provided.

@daivinhtran daivinhtran force-pushed the link_with_shared_library branch 2 times, most recently from a8dfc23 to 20beb96 Compare July 13, 2023 13:34
UebelAndre
UebelAndre requested changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Great idea!

I had just one request 😄

examples/ffi/rust_calling_c/BUILD.bazel
@@ -44,6 +44,25 @@ rust_library(
],
)

rust_library(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you also be able to add a rust_test maybe to show that the library can be used at runtime?

Copy link
Contributor Author

@daivinhtran daivinhtran Jul 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the request!

I added a rust_test here which is able to pass bazel run and bazel test locally but fails on CI. How would I reproduce this error locally?

@daivinhtran daivinhtran force-pushed the link_with_shared_library branch from 20beb96 to 2cb62f2 Compare July 15, 2023 01:30
@daivinhtran daivinhtran force-pushed the link_with_shared_library branch from 3db276e to e8bf194 Compare July 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daivinhtran @UebelAndre