Skip to content

add: menambah java generic multi parameter type #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2022
Merged

add: menambah java generic multi parameter type #129

merged 2 commits into from
Oct 9, 2022

Conversation

fairusatoir
Copy link
Collaborator

Deskripsi (Description)

Menambah contoh penggunaan java generic dengan menggunakan 2 atau lebih paremeter type

Checklist:

Umum:
  • Saya menambah algoritma terbaru.
  • Saya memperbaiki algoritma yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • OS = Linux
  • Java = 18

Link Issues

Issues : #128

@auto-add-label auto-add-label bot added the add label Oct 9, 2022
@mergify mergify bot requested a review from a team October 9, 2022 11:09
dean-fahreza
dean-fahreza reviewed Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@dean-fahreza dean-fahreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tapi bisakah menambahkan dokumentasi README.md pada generic class multi parameter ini? trima kasih

@mergify mergify bot requested a review from a team October 9, 2022 12:07
dean-fahreza
dean-fahreza approved these changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@dean-fahreza dean-fahreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now, really LGTM!

@fairusatoir
Copy link
Collaborator Author

LGTM, tapi bisakah menambahkan dokumentasi README.md pada generic class multi parameter ini? trima kasih

Dokumentasi README.md sudah ditambahkan ✅

@mergify mergify bot merged commit 08bf8e2 into bellshade:main Oct 9, 2022
@mergify
Copy link

mergify bot commented Oct 9, 2022

terima kasih atas kontribusinya @fairusatoir!

@mergify mergify bot requested a review from a team October 9, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dean-fahreza dean-fahreza dean-fahreza approved these changes

@slowy07 slowy07 Awaiting requested review from slowy07 slowy07 is a code owner

@sautmanurung1 sautmanurung1 Awaiting requested review from sautmanurung1 sautmanurung1 is a code owner

@bhimsur bhimsur Awaiting requested review from bhimsur bhimsur is a code owner

Assignees

@dean-fahreza dean-fahreza

@bellshadebot bellshadebot

Labels
add HACKTOBERFEST-ACCEPTED java files markdown files ready-to-merge siap merge request tim java untuk review sudah direview!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fairusatoir @dean-fahreza @bellshadebot