Skip to content

feat: Menambah java interface #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2021
Merged

feat: Menambah java interface #66

merged 2 commits into from
Nov 25, 2021

Conversation

fairusatoir
Copy link
Collaborator

@fairusatoir fairusatoir commented Nov 23, 2021 •
edited by dean-fahreza
Loading

Deskripsi (Description)

Checklist:

Umum:
  • Saya menambah algoritma terbaru.
  • Saya memperbaiki algoritma yang sudah ada.
  • Saya memperbaiki dokumentasi.
  • Saya menambah dokumentasi.
Contributor Requirements (Syarat Kontributor) dan Lain-Lain:
  • Saya sudah membaca (I have read) CONTRIBUTING dan sudah menyetujui semua syarat.
  • Saya telah menambahkan komentar kode yang memberikan penjelasan maksud dari kode yang saya buat.
  • Saya menggunakan bahasa Indonesia untuk memberikan penjelasan dari kode yang saya buat.

Environment

Saya menggunakan (I'm using):

  • os = linux
  • java = 11

linked issue #53

@auto-add-label auto-add-label bot added the enhancement New feature or request label Nov 23, 2021
@mergify mergify bot requested a review from a team November 23, 2021 14:36
bhimsur
bhimsur approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@bhimsur bhimsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tapi ada minor yang bisa diperbaiki seperti penamaan class bisa pakai PascalCase

@mergify mergify bot requested a review from a team November 24, 2021 00:55
@mergify mergify bot requested a review from a team November 24, 2021 01:45
dean-fahreza
dean-fahreza approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@dean-fahreza dean-fahreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mantap

@mergify mergify bot requested a review from a team November 24, 2021 07:23
@fairusatoir
Copy link
Collaborator Author

LGTM, tapi ada minor yang bisa diperbaiki seperti penamaan class bisa pakai PascalCase

Done

sautmanurung1
sautmanurung1 approved these changes Nov 24, 2021
View reviewed changes
Copy link
Collaborator

@sautmanurung1 sautmanurung1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team November 24, 2021 12:35
@dean-fahreza dean-fahreza merged commit 98b682b into bellshade:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhimsur bhimsur bhimsur approved these changes

@sautmanurung1 sautmanurung1 sautmanurung1 approved these changes

@dean-fahreza dean-fahreza dean-fahreza approved these changes

@ajo-universe ajo-universe Awaiting requested review from ajo-universe

@nomadkode nomadkode Awaiting requested review from nomadkode

Assignees
No one assigned
Labels
enhancement New feature or request java files markdown files request docs team untuk review request tim java untuk review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fairusatoir @bhimsur @sautmanurung1 @dean-fahreza