supporting standby server

[michaelxwang]

I have a backup consisting of the a primary and standby (which are not supported by us):

backend foo
...
    server primary <ip1>:<port> check
    server standby <ip1>:<port> check

as long as one of them is up, we are fine. I added a option to support this:

# diff -u check_haproxy.rb check_haproxy_new.rb 
--- check_haproxy.rb	2020-07-20 11:48:18.606961989 -0400
+++ check_haproxy_new.rb	2020-07-22 10:25:42.739437825 -0400
@@ -56,6 +56,10 @@
     options.insecure_ssl = true
   end
 
+  opts.on( '-o', '--overall', 'Reporting status based on the overall frontend/backup status' ) do
+    options.overall = true
+  end
+
   opts.on( '--http-error-critical', 'Throw critical when connection to HAProxy is refused or returns error code' ) do
     options.http_error_critical = true
   end
@@ -177,9 +181,11 @@
                     row['smax'])
   @proxies << message
 
-  if row['status'].include?('DOWN')
-    @errors << message
-    exit_code CRITICAL
+  if not options.overall or row['svname'] =~ /^(FRONTEND|BACKEND)$/
+    if row['status'].include?('DOWN')
+      @errors << message
+      exit_code CRITICAL
+    end
   end
 
   if options.critical && session_percent_usage >= options.critical.to_i

Please review. Thanks.

[benprew]

Hi @michaelxwang, thanks for submitting this patch. I had one question, previously the code used to report critical messages if a proxy was down, now it only reports critical messages if "overall" is specified, or the svname is frontend or backend.

I think a better solution would be to have an option to limit to specific svnames, then you could pass in backend,frontend as the list of acceptable svnames.

Would that work for you?

[benprew]

Maybe the svname would require a proxy as well, so instead of just specifying --svnames frontend,backend you could do something like --svnames foo|frontend,foo|backend if you wanted to filter to specific svnames in specific proxies.

[benprew]

@michaelxwang I think I have a fix for this in PR #19, can you test with that updated version of check_haproxy.rb when you get a chance to see if it fixes the issue? If not, can you provide a haproxy .csv file that I can test against?

Thanks