Skip to content

fix issue #7 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 5, 2017
Merged

fix issue #7 #8

merged 6 commits into from
Jan 5, 2017

Conversation

pulecp
Copy link

@pulecp pulecp commented Aug 25, 2016

Do not calculate statistics when there is no session so far. Return zero
instead of that.

Signed-off-by: Pavel Pulec [email protected]

Do not calculate statistics when there is no session so far. Return zero
instead of that.

Signed-off-by: Pavel Pulec <[email protected]>
@pulecp
Copy link
Author

pulecp commented Aug 25, 2016

  • allow https with invalid certificate

@pulecp
Copy link
Author

pulecp commented Aug 26, 2016

Allow first redirect. I force https on some haproxy stacks so this check is also redirected.

The check should be critical if the connection is refused
or if some HTTP error happens. That could mean that HAProxy
is not running.

Signed-off-by: Pavel Pulec <[email protected]>
@@ -4,12 +4,18 @@
require 'open-uri'
require 'ostruct'
require 'csv'
require 'openssl'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be conditionally required if the user enters an https url

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added options '-s' or '--ssl', see 1e3b0fa

Pavel Pulec added 2 commits August 31, 2016 11:04
Throw critical when connection to HAProxy is refused or returns error code

Signed-off-by: Pavel Pulec <[email protected]>
@pulecp
Copy link
Author

pulecp commented Aug 31, 2016

Please, check my changes.

I'm not Ruby guru so if you don't feel good about something, just tell me ;-)

@benprew
Copy link
Owner

benprew commented Sep 10, 2016

Pavel,

Sorry I haven't had a chance to look at this yet, I'll have more free
time at the end of the month to look at it.

Thanks

Ben Prew
[email protected]

On Wed, Aug 31, 2016, at 02:39 AM, Pavel Pulec wrote:

Please, check my changes.
I'm not Ruby guru so if you don't feel good about something, just
tell me ;-)
— You are receiving this because you commented. Reply to this email
directly, view it on GitHub[1], or mute the thread[2].

Links:

  1. fix issue #7 #8 (comment)
  2. https://github.com/notifications/unsubscribe-auth/AACT1-GdGWAr2Ikf8lMRJBiA5r7gX7mbks5qlUvNgaJpZM4JtBpJ

@benprew benprew merged commit 7327538 into benprew:master Jan 5, 2017
@benprew benprew mentioned this pull request Jan 5, 2017
@benprew
Copy link
Owner

benprew commented Jan 5, 2017

fixes #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants