-
Notifications
You must be signed in to change notification settings - Fork 13
fix issue #7 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #7 #8
Conversation
Do not calculate statistics when there is no session so far. Return zero instead of that. Signed-off-by: Pavel Pulec <[email protected]>
Signed-off-by: Pavel Pulec <[email protected]>
|
Signed-off-by: Pavel Pulec <[email protected]>
Allow first redirect. I force https on some haproxy stacks so this check is also redirected. |
The check should be critical if the connection is refused or if some HTTP error happens. That could mean that HAProxy is not running. Signed-off-by: Pavel Pulec <[email protected]>
@@ -4,12 +4,18 @@ | |||
require 'open-uri' | |||
require 'ostruct' | |||
require 'csv' | |||
require 'openssl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be conditionally required if the user enters an https url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added options '-s' or '--ssl', see 1e3b0fa
Signed-off-by: Pavel Pulec <[email protected]>
Throw critical when connection to HAProxy is refused or returns error code Signed-off-by: Pavel Pulec <[email protected]>
Please, check my changes. I'm not Ruby guru so if you don't feel good about something, just tell me ;-) |
Pavel, Sorry I haven't had a chance to look at this yet, I'll have more free Thanks Ben Prew On Wed, Aug 31, 2016, at 02:39 AM, Pavel Pulec wrote:
Links: |
fixes #7 |
Do not calculate statistics when there is no session so far. Return zero
instead of that.
Signed-off-by: Pavel Pulec [email protected]