Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT-6210 fix icons and content spacings in rli #478

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

pioziol123
Copy link
Contributor

No description provided.

@tweetgeek tweetgeek requested a review from Copilot March 27, 2025 09:13
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses IT-6210 by updating the spacing around icons and content areas in the RichList component. Key changes include:

  • Adjusting the padding values for drag-and-drop and icon wrapper elements.
  • Modifying the padding for various #{$root}__content blocks to update content spacing.
  • Removing the alignment and padding rules for #{$root}__content under the .-ds-small modifier.
Comments suppressed due to low confidence (2)

lib/js/components/RichList/RichListItem/RichListItem.vue:139

  • Ensure that the increased padding for the drag-and-drop and icon wrapper elements is consistent with the overall design guidelines, as it could affect alignment with adjacent elements.
padding: $space-3xs $space-5xs $space-3xs $space-s;

lib/js/components/RichList/RichListItem/RichListItem.vue:249

  • Double-check that the removal of the #{$root}__content styling under the .-ds-small modifier is intentional, as it may affect the layout on small displays.
#{$root}__content {

@tweetgeek
Copy link
Contributor

/review

Copy link

@tweetgeek tweetgeek merged commit 76b52fc into master Apr 8, 2025
1 check passed
@tweetgeek tweetgeek deleted the IT-6210_fix_icon_anc_content_spacings_in_rli branch April 8, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants