Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<location> support for asciidoctor and sass targets #439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grisumbras
Copy link
Contributor

Proposed changes

<location> is removed from property sets for SASS and ASCIIDOC targets. This makes them behave differently from other targets, and prevents users to put them into a specific place. Normally it can be circumvented using an install rule, but when multiple files are created it becomes less trivial. The change fixes the issue by whitelisting <location> feature for those types.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

@grisumbras grisumbras force-pushed the fix/support-location branch from 385d756 to 5f1a8b5 Compare March 17, 2025 10:24
@grafikrobot grafikrobot added the enhancement New feature or request label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

2 participants