-
-
Notifications
You must be signed in to change notification settings - Fork 576
feat(workspace): add semantic model debug printer #5821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ematipico
reviewed
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things are missing:
- update
workspace_types.rs
and add the new method - update
biome_wasm
and add the new method - add a test in
workspace.tests.rs
with a snapshot test
e41474b
to
a2d4a47
Compare
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
3f0dbcf
to
34aea50
Compare
34aea50
to
830c30d
Compare
CodSpeed Performance ReportMerging #5821 will not alter performanceComparing Summary
|
ematipico
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! 🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on
noShadow
, I found it kinda difficult to work with the semantic model because of the lack of a visual representation. This PR aims to resolve that by adding a debug printer for the semantic model.Test Plan
I've added this printer to the quick test for the analyzer. I didn't make any explicit tests since it's just debug output and not functionality that end users will be engaging with.