Skip to content

feat(workspace): add semantic model debug printer #5821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Apr 29, 2025

Summary

While working on noShadow, I found it kinda difficult to work with the semantic model because of the lack of a visual representation. This PR aims to resolve that by adding a debug printer for the semantic model.

Test Plan

I've added this printer to the quick test for the analyzer. I didn't make any explicit tests since it's just debug output and not functionality that end users will be engaging with.

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Apr 29, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things are missing:

  • update workspace_types.rs and add the new method
  • update biome_wasm and add the new method
  • add a test in workspace.tests.rs with a snapshot test

@dyc3 dyc3 force-pushed the dyc3/debug-semantic-model branch from e41474b to a2d4a47 Compare April 30, 2025 13:44
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 50451 50451 0
Passed 49136 49136 0
Failed 1315 1315 0
Panics 0 0 0
Coverage 97.39% 97.39% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6647 6647 0
Passed 2229 2229 0
Failed 4418 4418 0
Panics 0 0 0
Coverage 33.53% 33.53% 0.00%

ts/babel

Test result main count This PR count Difference
Total 807 807 0
Passed 718 718 0
Failed 89 89 0
Panics 0 0 0
Coverage 88.97% 88.97% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18698 18698 0
Passed 14346 14346 0
Failed 4352 4352 0
Panics 0 0 0
Coverage 76.72% 76.72% 0.00%

@dyc3 dyc3 force-pushed the dyc3/debug-semantic-model branch 2 times, most recently from 3f0dbcf to 34aea50 Compare April 30, 2025 14:11
@dyc3 dyc3 force-pushed the dyc3/debug-semantic-model branch from 34aea50 to 830c30d Compare April 30, 2025 14:25
Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Performance Report

Merging #5821 will not alter performance

Comparing dyc3/debug-semantic-model (830c30d) with main (74e5eb6)

Summary

✅ 95 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🌟

@dyc3 dyc3 merged commit 7373612 into main Apr 30, 2025
15 checks passed
@dyc3 dyc3 deleted the dyc3/debug-semantic-model branch April 30, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants