Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.md: add information on -c option #352

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

deepend-tildeclub
Copy link

added -c option to the how to run the bot. Without it I'm sure a ton of people had troubles with module loading and just gave up.

added -c option to the how to run the bot.   Without it I'm sure a ton of people had troubles with module loading and just gave up.
@examknow
Copy link
Member

examknow commented Jan 2, 2023

If the current configuration instructions are followed correctly, there is no need to pass the -c option as BitBot will look for the config file in ~/.bitbot/ by default.

@examknow examknow closed this Jan 2, 2023
@jesopo
Copy link
Member

jesopo commented Jan 2, 2023

i'm sure a lot of people want to keep the config file in a non-default location?

@examknow
Copy link
Member

examknow commented Jan 2, 2023

Fair, however, I think it should be made more clear that this is optional and only necessary if the config file is located in a non-standard location.

@examknow examknow reopened this Jan 2, 2023
@deepend-tildeclub
Copy link
Author

If the current configuration instructions are followed correctly, there is no need to pass the -c option as BitBot will look for the config file in ~/.bitbot/ by default.

Yeah totally misread that when I set it up.. So that is my fault for sure.

@examknow
Copy link
Member

examknow commented Jan 2, 2023

It may be worth having a section describing all of the optional arguments that can be passed to bitbotd although the argparser help already accomplishes this IMHO.

making -c a clearer option?
Copy link
Member

@examknow examknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small formatting nitpick

Co-authored-by: David Schultz <[email protected]>
Copy link
Member

@examknow examknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everybody's good with this, I'll merge later tonight. Thanks!

@examknow examknow changed the base branch from master to develop January 3, 2023 04:51
@examknow examknow changed the title Update config.md config.md: add information on -c option Jan 3, 2023
@examknow examknow merged commit 398aca2 into bitbot-irc:develop Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants