If -prune=0 is set, Uncheck Prune on Intro page

[jadijadi]

If the bitcoin-qt is started with -prune=0 arg, On the Intro page,
the Prune Checkbox will be unchecked too, to prevent confusions.

refs: bitcoin/bitcoin#25052

[ryanofsky]

This is a probably a good-enough fix and better than the status quo, but it could be improved in the futue:

• If -prune=size setting is given, size could be shown in intro dialog box (EDIT: Not true, this is actually already implemented)
• If data directory path is changed, and path contains bitcoin.conf or settings.json files with a prune value, that value could be shown.

But this fix is probably good enough to fix problem at hand

[jadijadi]

Thanks for the valuable comments. The first one is already working as intended. I took a note about the 2nd one and will work on it separately.
Thanks.

[jarolrod]

tACK 329c966

[shaavan]

Code Review ACK 329c966

• I find this to be a concise and straightforward fix to the issue it targets.

[w0xlt]

Code Review ACK 329c966

[hebasto]

When passing -prune= >1 to the command line, it forces the prune checkbox to be checked and disables it.

With this PR, when passing -prune=0 to the command line, it forces the prune checkbox to be unchecked but does not disable it.

Should behavior be consistent?

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

[ryanofsky]

When passing -prune= >1 to the command line, it forces the prune checkbox to be checked and disables it.

With this PR, when passing -prune=0 to the command line, it forces the prune checkbox to be unchecked but does not disable it.

Should behavior be consistent?

This is a good point. It would be better for behavior to be consistent and it would be better to disable the setting if leaving it enabled gives user the misleading impression that setting they are chosing in the checkbox will be applied. For example, if bitcoin is started with -prune=0 and checkbox is enabled and user checks, they could have misleading impression that pruning will be applied when it won't be. (Or at least it won't be applied until next startup. It may be applied next startup if command line argument is omitted at that time)

Even so, the PR in it's current form is still an improvement over the status quo. Disabling the checkbox would be an even bigger improvement, but just having checkbox show correct value is an improvement by itself.

[ryanofsky]

Code review ACK f4b0c0c

(Stylistically, I slightly prefer previous version of the PR 329c966 which does not use IsArgSet function, because I consider the IsArgSet method a major footgun that is used incorrectly 75% of the places where it is called. But in this case it is used correctly and both versions of the PR are equivalent)

[hebasto]

ACK f4b0c0c

Even so, the PR in it's current form is still an improvement over the status quo. Disabling the checkbox would be an even bigger improvement, but just having checkbox show correct value is an improvement by itself.

Agree. Could leave a bigger improvement for an follow up.

@jadijadi Please squash all commits into one before merging.

[jadijadi]

ACK f4b0c0c

Even so, the PR in it's current form is still an improvement over the status quo. Disabling the checkbox would be an even bigger improvement, but just having checkbox show correct value is an improvement by itself.

Agree. Could leave a bigger improvement for an follow up.

@jadijadi Please squash all commits into one before merging.

Thanks @hebasto , I squashed the commits into one.

[hebasto]

re-ACK 40566e2