Disable GCC suggest-override warnings for proxy clients #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy client methods are usually virtual, but in some use cases (testing, layering) they don't have to have to be and there is no reason to make generated client code try to detect or specify this. Disable the warning instead. Warnings look like https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 ./ipc/capnp/init.capnp.proxy.h:62:25: error: ‘virtual mp::FunctionTraits<std::unique_ptr<interfaces::Echo> (interfaces::Init::* const)()>::Result mp::ProxyClient<ipc::capnp::messages::Init>::makeEcho()’ can be marked override [-Werror=suggest-override] 62 | typename M1::Result makeEcho(); | ^~~~~~~~ cc1plus: some warnings being treated as errors
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 8, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin#35 bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin#37 bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin#38
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 11, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin#35 bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin#37 bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin#38
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 11, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 18, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Dec 18, 2020
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 28, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jan 28, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 4, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 4, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 4, 2021
Update libmultiprocess library Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 17, 2021
Update libmultiprocess library Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 17, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 17, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 30, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 30, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ariard
pushed a commit
to ariard/bitcoin
that referenced
this pull request
Apr 6, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Apr 23, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Apr 23, 2021
Fix "Disable GCC suggest-override warnings for proxy clients" bitcoin-core/libmultiprocess#40 is needed to prevent cirrus GCC failure https://cirrus-ci.com/task/6000489311502336?command=ci#L4294 This also includes other recent changes bitcoin-core/libmultiprocess#35 Fix README.md markdown bitcoin-core/libmultiprocess#37 Add "make check" target to build and run tests bitcoin-core/libmultiprocess#38 Add "extends" inherited method support bitcoin-core/libmultiprocess#41 Avoid depending on argument default constructors bitcoin-core/libmultiprocess#42 Support attaching custom cleanup functions to proxy client and server classes bitcoin-core/libmultiprocess#43 Drop hardcoded #include lines in generated files
ryanofsky
added a commit
to ryanofsky/libmultiprocess
that referenced
this pull request
Dec 22, 2021
Warnings look like "warning: 'initError' overrides a member function but is not marked 'override' [-Wsuggest-override]" Warnings were originally reported by Sjors Provoost <[email protected]> and are tracked in bitcoin-core#61 The same warnings were previously disabled for GCC in 05f9817 bitcoin-core#40 and that change is extended here to apply to clang. The methods triggering the warnings are not virtual in all cases and should not have the override keyword.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy client methods are usually virtual, but in some use cases (testing, layering) they don't have to have to be and there is no reason to make generated client code try to detect or specify this. Disable the warning instead.
Warnings look like https://cirrus-ci.com/task/6000489311502336?command=ci#L4294