Skip to content

Migrate more wallet primitives to macros #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2025
Merged

Migrate more wallet primitives to macros #743

merged 5 commits into from
Apr 25, 2025

Conversation

rustaceanrob
Copy link
Collaborator

KeychainKind, Balance, BlockId, ConfirmationBlockTime, ChainPosition, CanonicalTx

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@rustaceanrob
Copy link
Collaborator Author

1e84562 is rebased

thunderbiscuit
thunderbiscuit approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1e84562.

@thunderbiscuit thunderbiscuit merged commit 1e84562 into bitcoindevkit:master Apr 25, 2025
26 checks passed
@rustaceanrob rustaceanrob deleted the wallet-types-4-25 branch April 25, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustaceanrob @thunderbiscuit