Skip to content

Use macros for more crate::types #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Use macros for more crate::types #746

merged 1 commit into from
Apr 28, 2025

Conversation

rustaceanrob
Copy link
Collaborator

Description

AddressInfo, TxStatus, ScriptAmount, SentAndReceived, KeychainAndIndex

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

thunderbiscuit
thunderbiscuit approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 80df01a. Just needs a rebase.

@rustaceanrob rustaceanrob force-pushed the more-wallet-types-4-27 branch from 80df01a to 0ea6895 Compare April 28, 2025 13:14
@rustaceanrob
Copy link
Collaborator Author

0ea6895 is rebased

@thunderbiscuit thunderbiscuit merged commit 0ea6895 into bitcoindevkit:master Apr 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustaceanrob @thunderbiscuit