[PM-14485] Remove manifest and index.html logic from gulp #11861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11861 +/- ##
==========================================
- Coverage 33.48% 33.47% -0.01%
==========================================
Files 2844 2844
Lines 89044 89044
Branches 16987 16987
==========================================
- Hits 29812 29805 -7
- Misses 56887 56894 +7
Partials 2345 2345 ☔ View full report in Codecov by Sentry. |
justindbaur
previously approved these changes
Nov 5, 2024
|
New Issues
Fixed Issues
|
Hinton
commented
Nov 7, 2024
| @@ -125,20 +151,26 @@ | |||
| "overlay/list.html", | |||
| "popup/fonts/*" | |||
| ], | |||
| "applications": { | |||
| "__firefox__browser_specific_settings": { | |||
There was a problem hiding this comment.
applications is deprecated since > 5 years ago, and we should use browser_specific_settings.
Hinton
changed the title
…gulp # Conflicts: # package-lock.json
justindbaur
previously approved these changes
Nov 7, 2024
Hinton
commented
Nov 7, 2024
| @@ -121,7 +121,7 @@ jobs: | |||
| PACKAGE_VERSION: ${{ needs.setup.outputs.release-version }} | |||
| run: | | |||
| mv browser-source.zip browser-source-$PACKAGE_VERSION.zip | |||
| mv dist-chrome-mv3.zip dist-chrome-$PACKAGE_VERSION.zip | |||
| mv dist-chrome.zip dist-chrome-$PACKAGE_VERSION.zip | |||
There was a problem hiding this comment.
@bitwarden/dept-bre do we have any good way of testing the release flow? Run a dry-run in this branch and confirm it works?
…gulp # Conflicts: # package-lock.json # package.json
justindbaur
previously approved these changes
Nov 13, 2024
vgrassia
previously approved these changes
Nov 13, 2024
This was referenced Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14485
📔 Objective
Refactor the remaining logic from gulp.
Part of the browser build script refactor effort. bitwarden.atlassian.net/browse/PM-6683
Webpack is now responsible for performing most of the operations previously done by gulp. This includes:
The
package.jsonis modified to include browser specific commands forbuild,build:prod,build:watchanddist.Manifests
Manifests now uses the
copy-webpack-plugintransformfeature. The logic is located inapps/browser/webpack/manifest.js. It reads a template, which supports some basic operations primarily overriding with browser specific fields using__browser__.The
manifest.jsonfor both regular and mv3 builds are identical to our existing manifests except:applicationsrenamed tobrowser_specific_settings.permissionssorted alphabetically.Safari build
Safari requires additional packaging commands. This is implemented as a powershell script due to the cross-platform nature, and since we generally require powershell in our distribution pipelines.
An alternative would be to write it in bash, but bash is less powerful and would require some additional commands like
jq. Another alternative is to write it using js, but that would require additional dependencies.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes