Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth/ps 2465 fix knowndevices path #4710

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Auth/ps 2465 fix knowndevices path #4710

merged 5 commits into from
Mar 7, 2023

Conversation

MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Feb 9, 2023 •
edited
Loading

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Prefer query parameters for things like email. As a part of this, I had to split paths prior to normalization due to parameters being given as part of the path argument to send

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@MGibson1 MGibson1 requested review from a team February 9, 2023 23:07
JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. I don't expect there to be any issues with the update to the path normalization logic, but it might be worth mentioning that you enhanced that on the PR for future traceability.

@MGibson1
Copy link
Member Author

@JaredSnider-Bitwarden , comment updated. Do you think you could take a look at the companion bitwarden/server#2682?

JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this! 👍

@MGibson1 MGibson1 merged commit a16d02b into master Mar 7, 2023
@MGibson1 MGibson1 deleted the auth/ps-2465-fix-knowndevices-path branch March 7, 2023 18:49
@justindbaur justindbaur mentioned this pull request Mar 10, 2023
Merged
This was referenced May 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredSnider-Bitwarden JaredSnider-Bitwarden JaredSnider-Bitwarden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGibson1 @JaredSnider-Bitwarden