Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SARIF upload branch ref/sha #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mandreko-bitwarden
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

https://bitwarden.atlassian.net/browse/VULN-226

๐Ÿ“” Objective

Add correct ref/sha reference for main and PR branches, since codeql/upload-sarif doesn't handle pull_request_target properly.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@mandreko-bitwarden mandreko-bitwarden requested a review from a team as a code owner March 20, 2025 14:01
Copy link

Deploying contributing-docs with ย Cloudflare Pages ย Cloudflare Pages

Latest commit: c3c2ea8
Status:ย โœ…ย  Deploy successful!
Preview URL: https://205b9f08.contributing-docs.pages.dev
Branch Preview URL: https://sarif-upload-branch-fix.contributing-docs.pages.dev

View logs

Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f7eb0130-a659-495a-b049-261a09690b29

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CVE-2025-27789 Npm-@babel/helpers-7.26.0 Vulnerable Package
MEDIUM CVE-2025-27789 Npm-@babel/runtime-corejs3-7.26.0 Vulnerable Package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants