Skip to content

Fix handling of various compile commands #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

bkryza
Copy link
Owner

@bkryza bkryza commented Nov 21, 2024

Fixes #341

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.60%. Comparing base (644e4a0) to head (d2a9970).

Files with missing lines Patch % Lines
src/common/compilation_database.cc 41.66% 14 Missing ⚠️
src/config/config.cc 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   90.69%   90.60%   -0.10%     
==========================================
  Files         136      136              
  Lines       16827    16842      +15     
==========================================
- Hits        15262    15260       -2     
- Misses       1565     1582      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bkryza bkryza merged commit 972dbea into master Nov 21, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix handling of compile_commands.json with relative paths
1 participant