Skip to content
This repository was archived by the owner on Jan 8, 2019. It is now read-only.

fix ldapsearch for hdfs dir creation #1254

Merged
merged 2 commits into from
Aug 8, 2018

Conversation

macmaster
Copy link
Contributor

These changes should allow hdfs user and group directory provisioning to work in bcpc-hadoop with ldapsearch commands. Some hdfs attributes have been refactored to logically group them in an ldap.rb attributes file. I have tested these changes on a hardware cluster.

@cbaenziger
Copy link
Member

Feel free to call this a bike shed, but dirs.rb->create_dirs.rb?

Copy link
Member

@vt0r vt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@aespinosa aespinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vt0r vt0r merged commit 7531d3a into bloomberg:master Aug 8, 2018

# set space quota
if quotas[dir]
max_quota = HdfsConstants::QUOTA_DONT_SET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not use HdfsConstants.QUOTA_RESET?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants