This repository was archived by the owner on Jan 8, 2019. It is now read-only.
Copy jRuby users/groups script to new projects one #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macmaster
approved these changes
Aug 10, 2018
| ns_quota = | ||
| info['ns_quota'] || | ||
| node['bcpc']['hadoop']['hdfs']['projects']['ns_quota'] | ||
| [ |
There was a problem hiding this comment.
I think we can cut out some redundancy here.
dirinfo_hash = dirinfo.map do |dir, info|
[ dir, {
'owner' => info['owner'] ||
node['bcpc']['hadoop']['hdfs']['projects']['owner'],
'group' => info['group'] ||
node['bcpc']['hadoop']['hdfs']['projects']['group'],
'perms' => info['perms'] ||
node['bcpc']['hadoop']['hdfs']['projects']['perms'],
'space_quota' => info['space_quota'] ||
node['bcpc']['hadoop']['hdfs']['projects']['space_quota'],
'ns_quota' => info['ns_quota'] ||
node['bcpc']['hadoop']['hdfs']['projects']['ns_quota']
} ]
end.to_h
Also, the reason we needed to use symbols in the jruby script is because we used symbol keys for the hash here.
We could stay consistent by using string keys here.
vt0r
added a commit
that referenced
this pull request
Aug 10, 2018
* Copy jRuby users/groups script to new projects one * Cleanup on dirinfo_hash assignments - feedback (cherry picked from commit 402b01f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this is duplication. The intent is to extend this newer version to support the user/groups directory creation the original is currently doing, bringing the number of jRuby scripts back down to the desired number (1).