Skip to content
This repository was archived by the owner on Jan 8, 2019. It is now read-only.

remove default value which gets merged and fails chef-client run #1262

Merged

Conversation

leochen4891
Copy link
Contributor

the default value ends up merged with the actual value, and fails the chef-client run

{
  "appfoo"=> {
    "repo_url"=>"http://bcpc.example.com",
    "copy_to"=>"",
    "copy_type"=>"file",
    "runas"=>"root",
    "filename"=>"example.jar",
    "filemode"=>"0644",
    "fileowner"=>"root",
    "checksum"=>"4bd"
  },
  "myapp"=> {
    "repo_url"=> "<some url>",
    "copy_to"=>"<some local dir>",
    "copy_type"=>"file",
    "runas"=>"root",
    "filename"=>"<my jar file name>",
    "filemode"=>"0644",
    "fileowner"=>"root",
    "checksum"=> "<my check sum>"
  }
}

@cbaenziger
Copy link
Member

Do we not run the recipe which consumes this normally in VM clusters? It seems like we should have something to actually test this code -- not that appfoo looks to do that.

@leochen4891
Copy link
Contributor Author

@cbaenziger
This is a wrapper for cd66406
which is not included in any of the VM host's run_list.
Given the existence of #1207, this wrapper seemed not having unit tests at the time of creation, and needs further updates. That being said, this PR is aimed to fix an issue that's causing error on physical clusters.

@cbaenziger cbaenziger merged commit 72913ea into bloomberg:master Aug 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants