-
Notifications
You must be signed in to change notification settings - Fork 66
Add bach web portal page #1266
Add bach web portal page #1266
Conversation
9b343a6
to
d5efd2c
Compare
.rubocop.yml
Outdated
@@ -1,3 +1,6 @@ | |||
AllCops: | |||
TargetRubyVersion: 2.3 | |||
DisplayCopNames: true | |||
|
|||
Metrics/LineLength: | |||
Max: 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you delete the entry entirely, the default is 80.
6a9cfdb
to
1b0da50
Compare
bbd1467
to
134b46a
Compare
Updated and tested. Ready to review and merge. |
Hi @leochen4891, do you have any documentation the structure of the Apache file layout after this change? My attempt to build Chef-BACH seems to be breaking due to an empty Also, it seems |
The Apache files layout after this change is to keep bach_bach related files under /var/www/bach/, which contains a sub-dir "files" to expose files. The reason I didn't override the existing index.html.erb and virtual host is that I was thinking of adding bach_web as a new set of pages, but not necessarily at the top level directory. I would have no objection if you suggest overriding existing index.html.erb and virtual host is a better way.
|
The next issue I hit was:
|
The dir |
The cause of the missing directory is worker nodes doesn't need the xxxx_web recipes , and should be fixed by #1276 |
The page is designed to provide:
Needs review,
please don't merge.also added a json end point "/json"