Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate analysis from graph, esModuleFlag as analysis info #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guybedford
Copy link
Collaborator

This PR adds the following:

  1. Separating the graph walking and file system calls from a "pure" analysis function in analysis.js.
  2. The analysis function now returns { staticAssignmentNames, exportsAllFrom, esModuleFlag }, where exportsAllFrom are unresolved specifiers and esModuleFlag is a boolean indicating if an __esModule flag was set to truthy.
  3. The default filtering is no longer included by default - rather it is down to the exact wrapper module implementation to handle this. In discussion with @jkrems we were able to come to a compromise that default should always be present on CommonJS module representations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant