Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make real concept constexpr #942

Closed
wants to merge 1 commit into from

Conversation

mborland
Copy link
Member

@mborland mborland commented Feb 4, 2023

With C++14 we can have multi-line constexpr member functions so make real_concept support constexpr construction and operations. Should fix the build errors in #937.

@jzmaddock
Copy link
Collaborator

Sorry wrong fix: we want real_concept to model our absolute minimal requirements, and there are number types (for example multiprecision types which reference C library backends such as MPFR) which can never be constepxr.

@mborland
Copy link
Member Author

mborland commented Feb 4, 2023

On an unrelated note if we are going to expand constexpr support in C++14 it might be worth dropping MSVC-14.0. It was unhappy in the PRs with tables, is doing the wrong thing here, and from this pr is missing support to full C++14. For now I think we are OK, but worth being aware of.

@NAThompson for awareness

@mborland mborland closed this Feb 4, 2023
@NAThompson
Copy link
Collaborator

@mborland , @jzmaddock : Does MSVC do autoupdates now? Certainly on Mac it is a task of some difficulty to stay on an old AppleClang version.

@mborland
Copy link
Member Author

mborland commented Feb 4, 2023

You can still download old versions on the website https://visualstudio.microsoft.com/vs/older-downloads/. To get an older Apple Clang build I have to login with an Apple Developer account, and it still tries to update every time you launch. This was a problem when Ventura was released but the toolchains hadn't been updated yet...

@ckormanyos
Copy link
Member

if we are going to expand constexpr support in C++14 it might be worth dropping MSVC-14.0

MSVC-14.0 cannot handle C++14 constexpr reliably. If you would like to use the acutal word constexpr without workarounds and within a C++14-compatible environment, the MSVC-14.0 must be dropped.

@mborland mborland deleted the real_concept branch February 5, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants