Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add margin below check boxes in the vertical layout #638

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Add margin below check boxes in the vertical layout #638

merged 1 commit into from
Apr 29, 2022

Conversation

donv
Copy link
Collaborator

@donv donv commented Apr 28, 2022

For vertical layouts and a single check box, the form group should have a bottom margin.

@donv donv requested review from lcreid and thimo April 28, 2022 13:16
lcreid
lcreid approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@lcreid lcreid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this contribution.

@donv
Copy link
Collaborator Author

donv commented Apr 29, 2022

Thanks! I really like how we now can verify the change with a visual example 😄 .

@donv donv merged commit 7529f5d into main Apr 29, 2022
@donv donv deleted the add_margin_below_check_boxes branch April 29, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcreid lcreid lcreid approved these changes

@thimo thimo Awaiting requested review from thimo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donv @lcreid @UweKubosch