Requirements checker now logs to stderr

[arnegroskurth]

Fixes #678

[theofidry]

Thanks for the PR!

A few nitpicks but looks good to me! Since there is so much changes for the next release I'd more confident to tag a new minor version.

[theofidry]

🤔 not sure why the End-to-End Tests / e2e-Tests: e2e_check_requirements build is failing. The build is passing on master so it should be related, but tee should pick up the stderr

[arnegroskurth]

thinking not sure why the End-to-End Tests / e2e-Tests: e2e_check_requirements build is failing. The build is passing on master so it should be related, but tee should pick up the stderr

I'm not really able to interpret the output but the latter failing test-case seems to complain about failed writes due to potentially full disk: https://github.com/box-project/box/runs/7039442617?check_suite_focus=true#step:6:2056

And I don't think that teeforwards stderr (Try: sh -c "echo foo > /dev/stderr" | tee file.ext) - where is that used? Just setting BOX_REQUIREMENTS_CHECKER_LOG_TO_STDOUT=1 for all tests might be the easiest way out here.

[theofidry]

I'm not really able to interpret the output but the latter failing test-case seems to complain about failed writes due to potentially full disk

Yes you can ignore this one I need to check how to fix it.

where is that used?

In the Makefile. You should be able to run the tests with make e2e_check_requirements

[theofidry]

Thank a lot @arnegroskurth