Use constants instead of #define for parameters #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't sure about preferred capitalization because the existing code seems inconsistent. |
| static const int Automatic = 1; | ||
| static const int Manual = 0; | ||
| static const int Direct = 0; | ||
| static const int Reverse = 1; |
There was a problem hiding this comment.
It will properly be better to use uint8_t instead of int here. Also why not use enums instead? This would prevent people calling the functions with the wrong argument.
There was a problem hiding this comment.
Because I have almost no idea what I'm doing with C++. 😄 Good suggestion -- I will explore it.
|
Closing to explore @Lauszus suggestion. I have screwed around with my forks so I will have to reopen a new PR with any changed commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids name conflicts.