-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aidbox Forms renderer #42
base: master
Are you sure you want to change the base?
Conversation
Thanks, this looks really cool, will demo it at DevDays, but might take some more time to get into dev/prod yet.
Also if practical
|
Thank you for your feedback.
The footer is now hidden. I also make the header non sticky to save some vertical space on the page.
Changes are immediately propagated. Show Response button always receives current QR. The submit button just sets the QR status to completed.
I couldn't find a way to how to pass QR to the renderer. My Vue knowledge is quite limited 😄. But I've added code examples in case you decide to implement passing QR down to the renderer. |
Hi @brianpos, I have addressed the requested changes. Please let me know if there is anything else needed to merge this PR. Thank you! |
Hi @brianpos, I’ve updated the pull request by replacing the iframe with Aidbox Forms web components, which encapsulate the iframe mounting and message passing, reducing the amount of boilerplate code. I also had to unhide the bottom toolbar and link the logic of the “Show Response” button to the “Save/Amend” buttons, as the “Show Response” button was overlapping with the top toolbar. Additionally, the Aidbox Forms renderer can now correctly display an existing QR sent from other renderers. Looking forward to your feedback! |
I'll take a look soon! |
cb488c9
to
f8a8269
Compare
Resolved the conflicts and squashed the commits |
No description provided.