Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aidbox Forms renderer #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

olimsaidov
Copy link

No description provided.

@brianpos
Copy link
Owner

brianpos commented Jun 10, 2024

Thanks, this looks really cool, will demo it at DevDays, but might take some more time to get into dev/prod yet.
Would you be able to implement the following:

  • A way to retrieve the current QR value (via the Show Response button - without having to click the submit button)
  • A way to render an existing QR (which is sent from the other renderers)

Also if practical

  • An option to hide the toolbar across the bottom - as really testing the rendering engine, not the submission/print engines (though the print is cool)

@olimsaidov
Copy link
Author

olimsaidov commented Jun 13, 2024

Thank you for your feedback.

An option to hide the toolbar across the bottom - as really testing the rendering engine, not the submission/print engines.

The footer is now hidden. I also make the header non sticky to save some vertical space on the page.

A way to retrieve the current QR value (via the Show Response button - without having to click the submit button)

Changes are immediately propagated. Show Response button always receives current QR. The submit button just sets the QR status to completed.

A way to render an existing QR (which is sent from the other renderers)

I couldn't find a way to how to pass QR to the renderer. My Vue knowledge is quite limited 😄. But I've added code examples in case you decide to implement passing QR down to the renderer.

@olimsaidov
Copy link
Author

Hi @brianpos,

I have addressed the requested changes. Please let me know if there is anything else needed to merge this PR.

Thank you!

@olimsaidov
Copy link
Author

Hi @brianpos,

I’ve updated the pull request by replacing the iframe with Aidbox Forms web components, which encapsulate the iframe mounting and message passing, reducing the amount of boilerplate code. I also had to unhide the bottom toolbar and link the logic of the “Show Response” button to the “Save/Amend” buttons, as the “Show Response” button was overlapping with the top toolbar.

Additionally, the Aidbox Forms renderer can now correctly display an existing QR sent from other renderers.

Looking forward to your feedback!

@brianpos
Copy link
Owner

I'll take a look soon!

@olimsaidov olimsaidov force-pushed the master branch 2 times, most recently from cb488c9 to f8a8269 Compare December 19, 2024 03:37
@olimsaidov
Copy link
Author

Resolved the conflicts and squashed the commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants